feat(tui): start the dev server when dev is picked from the menu - #2469
Merged
Merged
Conversation
agentcore-devx-automation
Bot
added
agentcore-harness-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
![agentcore-devx-automation[bot]](https://avatars.githubusercontent.com/u/2232217?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Nice, clean design. A few things I checked and think are worth noting rather than blocking on:
handoffArgscorrectly filters togetOptionValueSource === "cli"so defaults and env-sourced values aren't re-emitted (env is re-read on the second parse anyway), and the booleanvalue === !option.negatehandling covers both--flagand--no-flagcases. The added unit test locks this in.- The handoff test in
tui.test.tsxusesinTempDirectory+ttyTestIOand asserts on a realProjectStateErrorbubbling out ofdev, which is a proper behavior test — good use of real dependencies rather than mocking the router. - Re-entrancy is safe because
devis not insupportedTuiCommands, so its effectivedoesSupportTui()is false andwithTuiWhenInteractivewon't recursively launch the TUI on the handed-off invocation. Worth remembering if a future handed-off command is TUI-supported at its own node. - Telemetry-wise, the single
CommandRunMetricEventfor the process will end up withis_tui: true(set inrenderTuiAt) andcommand_path: ["agentcore","dev"]after the secondparseAsync— that seems like the right attribution for a handoff.
Nothing that needs changing before merge.
agentcore-devx-automation
Bot
removed
the
agentcore-harness-reviewing
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor #2469 +/- ##
=========================================
Coverage 97.24% 97.24%
=========================================
Files 615 617 +2
Lines 43804 43848 +44
=========================================
+ Hits 42596 42639 +43
- Misses 1208 1209 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Picking dev in the interactive menu used to show its help and tell the user to run `agentcore dev`. It now closes the menu and runs the dev command with no arguments, keeping any global flags (such as --region) the menu was launched with. 💘 Generated with Crush Assisted-by: Crush:us.anthropic.claude-opus-5-5
AlexanderRichey
force-pushed
the
feat/tui-dev-handoff
branch
from
September 30, 2026 01:11
d4889d6 to
aa58d3a
Compare
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
nborges-aws
approved these changes
Sep 30, 2026
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Picking
devin the interactive menu used to open a help page saying the command runs from the command line, so the user had to quit and typeagentcore devthemselves. Now the menu closes and the dev server starts, just as ifagentcore devhad been typed. Global flags given when the menu was opened (such as--region) carry over. Region choices made inside the menu do not.runtime shell, which pauses the menu and comes back to it. Doing that for dev would mean restructuring how the dev command starts up; that is left as a possible follow-up.Related Issue
Closes #
Documentation PR
Not applicable. The command reference is unchanged because no command names, flags, or descriptions changed.
Type of Change
Testing
How have you tested the change?
bun testbun run test:e2e, or explained why they are not applicable. Not applicable: the change affects only the interactive menu, which the end-to-end suite does not drive.bun run typecheckbun run lint:checkbun run format:checkbun run buildsrc/assets/, I updated affected snapshots withbun test <test-file> --update-snapshotsand committed themNew tests open the menu outside a project, pick
dev, and check that the dev command's own "not in a project" error comes back, which shows the command actually ran. A second test checks that launch flags are passed along.Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.
💘 Generated with Crush